Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Semigroup for Validated #716

Merged
merged 2 commits into from
Dec 6, 2015
Merged

Adds Semigroup for Validated #716

merged 2 commits into from
Dec 6, 2015

Conversation

mikejcurry
Copy link
Contributor

Added a Semigroup for Validated based on comment:
https://github.com/non/cats/pull/715#issuecomment-162326224

On a side note, I think there is at least one other Monoid instance (Xor) that has the same characteristics, i.e. no separate Semigroup instance . Seems based on the referenced comment it would be good to add these too?

@ceedubs
Copy link
Contributor

ceedubs commented Dec 6, 2015

Thanks! Looks good to me. 👍 if/when the build passes.

👍 for your suggestions of an Xor Semigroup as well. Good catch.

@codecov-io
Copy link

Current coverage is 85.48%

Merging #716 into master will increase coverage by +0.01% as of 3971b69

@@            master    #716   diff @@
======================================
  Files          162     162       
  Stmts         2237    2239     +2
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           1912    1914     +2
  Partial          0       0       
  Missed         325     325

Review entire Coverage Diff as of 3971b69

Powered by Codecov. Updated on successful CI builds.

mikejcurry added a commit to mikejcurry/cats that referenced this pull request Dec 6, 2015
@mikejcurry
Adds Semigroup for Xor
b7dd217 
As per typelevel#716, adding a Semigroup for the Xor data type which currently
has a Monoid instance but no Semigroup instance.
@mikejcurry mikejcurry mentioned this pull request Dec 6, 2015
Merged
@mikejcurry
Copy link
Contributor Author

Pushing a change as per #717 to keep things in line with naming conventions for tests. More specifically, changing the text in the test name from "Monoid[Validated[String, Int]]" to "Validated[String, Int]"

@non
Copy link
Contributor

non commented Dec 6, 2015

👍

non added a commit that referenced this pull request Dec 6, 2015
@non
Merge pull request #716 from mikejcurry/validated-semigroup
519228a 
Adds Semigroup for Validated
@non non merged commit 519228a into typelevel:master Dec 6, 2015
@non
Copy link
Contributor

non commented Dec 6, 2015

Thanks!

@mikejcurry mikejcurry deleted the validated-semigroup branch December 11, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikejcurry @ceedubs @codecov-io @non